Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix the shared_lint cached key #30609

Merged

Conversation

arthur-mountain
Copy link
Contributor

@arthur-mountain arthur-mountain commented Aug 6, 2024

Summary

In the shared_lint,

for the first Prettier job, use ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('yarn.lock') }} as the cache key.

For the following jobs, use ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }} as the cache key.

Some of the jobs do not hit the cache if the hash does not match.

How did you test this change?

I run act locally to test it.

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 11:59am

@react-sizebot
Copy link

Comparing: 187dd6a...cb37da0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 500.37 kB 500.37 kB = 89.80 kB 89.80 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 507.50 kB 507.50 kB = 90.96 kB 90.96 kB
facebook-www/ReactDOM-prod.classic.js = 595.24 kB 595.24 kB = 105.55 kB 105.55 kB
facebook-www/ReactDOM-prod.modern.js = 571.54 kB 571.54 kB = 101.75 kB 101.75 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 82db6eb

@poteto
Copy link
Member

poteto commented Aug 6, 2024

Thanks!

Rust failures are unrelated, fixing in #30616

@poteto poteto merged commit eb52f37 into facebook:main Aug 6, 2024
186 of 188 checks passed
@arthur-mountain
Copy link
Contributor Author

Thanks!

Rust failures are unrelated, fixing in #30616

Understood!!! Thank you very much~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants